-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint all files in a directory #5676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not look into detail but this looks promising, thank you @matusvalo. #352 is the base issue, #4217 is another approach for reference and it would need to be closed if we merge this.
This PR is now in draft mode. Pending points:
I would like to ask just for high level review whether the approach is right one. |
I missed #4217 since it is not linked to the issue. I let the decision to maintainers which PR should be finished (or maybe merged together - I had not look into #4217 yet). Please let me know what is your preference. |
The other PR got stalled for a long time because of this scary comment. (I've not looked at the issue for a long time and maybe not sufficiently in depth at the time but it seems it was overwhelming for the original implementer). Do you think this would be a problem with your approach ? |
I will check that. |
@Pierre-Sassoulas I have created additional PR trying to solve the issue with problems around |
Closing in favour of #5682 |
Type of Changes
Description
This PR adds new parameter
--discover-files
which switches pylint into mode when it iterates over FS subtree and executes pylint on all.py
files within this subtree regardless they are in package or not. But in the other hand this PR honours package name in the final output.Example consider following subtree:
The pylint output with no switch will be following:
The pylint output with switch will be following:
Closes #352