Add confidence level CONTROL_FLOW
#5709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1751055192
💛 - Coveralls |
There was a problem hiding this comment.
Looks good thank you !
The multiple place to modify to add a value makes me want to refactor Confidence to be an Enum instead because namedtuple are slow to import (as it's an exec). But this would make a breaking change and adding a confidence value will not happen that often if we're being honest. But maybe we need to do this breaking change before using confidence more, what do you think @DanielNoord ?
Pierre-Sassoulas
added
Enhancement ✨
Pierre-Sassoulas
approved these changes
Jan 24, 2022
DanielNoord
reviewed
Jan 24, 2022
|
I fixed the conflict and merged main but I think this could be squashed then rebased for clarity. |
jacobtylerwalls
force-pushed
the
control-flow-confidence
branch
from
2e66f1d to
bfff04e
Compare
jacobtylerwalls
force-pushed
the
control-flow-confidence
branch
from
bfff04e to
0f541d4
Compare
DanielNoord
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Add a new confidence level
CONTROL_FLOWfor messages emitted that depend on assumptions about control flow execution. Discussed at #5684 (comment).