Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress unsubscriptable-object warnings in type-checking blocks #5720

Merged
merged 4 commits into from
Apr 9, 2022
Merged

Suppress unsubscriptable-object warnings in type-checking blocks #5720

merged 4 commits into from
Apr 9, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Jan 25, 2022 •
edited by jacobtylerwalls
Loading

Type of Changes

Type
✓ 🐛 Bug fix

Description

Fixes #3979. Statements under if TYPE_CHECKING are not evaluated at runtime. That's why you can subscript otherwise unsubscriptable objects!

@Pierre-Sassoulas Pierre-Sassoulas added Bug 🪲 Regression False Positive 🦟 A message is emitted but nothing is wrong with the code labels Jan 25, 2022
@Pierre-Sassoulas Pierre-Sassoulas linked an issue Jan 25, 2022 that may be closed by this pull request
E1136: False positive when used with typing (mypy) patterns #3979
Closed
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the unsuscriptable-object-regression branch from 0e906d8 to 55fc8b1 Compare January 25, 2022 19:16
@jacobtylerwalls jacobtylerwalls added this to the 2.14.0 milestone Apr 9, 2022
@jacobtylerwalls jacobtylerwalls changed the title Add a regression test for issue #3979 and fix it Suppress unsubscriptable-object warnings in type-checking blocks Apr 9, 2022
@coveralls
Copy link

coveralls commented Apr 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2141248550

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.895%
Totals Coverage Status
Change from base Build 2141000809: 0.0%
Covered Lines: 15888
Relevant Lines: 16921
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas commented Apr 9, 2022
View reviewed changes
Copy link
Member Author

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't approve a MR I myself opened but thank you @jacobtylerwalls, LGTM.

jacobtylerwalls
jacobtylerwalls approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@Pierre-Sassoulas Pierre-Sassoulas merged commit 620347a into main Apr 9, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the unsuscriptable-object-regression branch April 9, 2022 17:27
@jacobtylerwalls
Copy link
Member

@Pierre-Sassoulas I suppose this is a backport candidate to 2.13, if we're willing to fiddle with the changelogs. It's not critical.

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.14.0, 2.13.8 May 1, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer label May 1, 2022
Pierre-Sassoulas added a commit that referenced this pull request May 2, 2022
@Pierre-Sassoulas @jacobtylerwalls
Suppress unsubscriptable-object warnings in type-checking blocks (#…
22ce1a5 
…5720)

* Add a regression test for issue #3979

* Don't emit `unsubscriptable-object` for statements in type-checking blocks

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Pierre-Sassoulas added a commit that referenced this pull request May 2, 2022
@Pierre-Sassoulas @jacobtylerwalls
Suppress unsubscriptable-object warnings in type-checking blocks (#…
ec2eee8 
…5720)

* Add a regression test for issue #3979

* Don't emit `unsubscriptable-object` for statements in type-checking blocks

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@DanielNoord DanielNoord added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
Backported Bug 🪲 False Positive 🦟 A message is emitted but nothing is wrong with the code Regression
Projects
None yet
Milestone
2.13.8
Development

Successfully merging this pull request may close these issues.

E1136: False positive when used with typing (mypy) patterns
4 participants
@Pierre-Sassoulas @coveralls @jacobtylerwalls @DanielNoord