Fix false positive used-before-assignment for named expressions in ternary operators
#5748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ternary operators
Pull Request Test Coverage Report for Build 1768856502
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Jan 30, 2022
Pierre-Sassoulas
added
the
False Positive 🦟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Extend an existing special case in the variables checker ("Single statement if, with assignment expression on same line as assignment") to include assignment expressions inside ternary operator tests used in calls (keyword or positional arguments).
Closes #5177
Closes #5212