Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert for functional tests directories structure #5757

Closed
wants to merge 1 commit into from

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Similar to #5753 but another implementation

@DanielNoord
Copy link
Collaborator

I don't have a preference opinion wise. The only thing my implementation adds is that also checks whether any tests should be moved to a sub-directory. So u/used_test.py should be in u/used/....
The PR itself became quite large sadly as there are a lot of directories that turned out to be wrong... Not sure in which PR we should continue the discussion, but let me know what you think!

@Pierre-Sassoulas
Copy link
Member Author

Let's keep the other one, better general state and more work done already.

@cdce8p cdce8p deleted the functional-rules branch February 1, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants