Fix matching note tags with a non-word char last #5859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using "\b" at the end of these patterns will only match note tags that
end in an alphanumeric character, immediately followed by a
non-alphanumeric character, or the end of the string. This is due to
"\b" being defined as a boundary between a word character ("\w") and a
non-word character ("\W"), or the end of the string. This leads to
deviations like "???" being ignored when specified.
Swapping "\b" for a positive lookahead that targets a whitespace, a
colon, or the end of a string accounts for this.
Closes pylint-dev#5840.
Pierre-Sassoulas
approved these changes
Mar 4, 2022
Pierre-Sassoulas
added
Bug 🪲
False Negative 🦋
DanielNoord
approved these changes
Mar 4, 2022
|
Congratulation on becoming a pylint contributor 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Using
\bat the end of the patterns for note tags will only match ones that end in an alphanumeric character, immediately followed by a non-alphanumeric character, or the end of the string. This is due to\bbeing defined as a boundary between a word character (\w) and a non-word character (\W), or the end of the string. This leads to deviations like???being ignored when specified.Swapping
\bfor a positive lookahead that targets a whitespace, a colon, or the end of a string accounts for this.Closes #5840.