-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disabling of ungrouped-imports
#5903
Conversation
Pull Request Test Coverage Report for Build 1974038123
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@jacobtylerwalls I totally forgot I added that method. Anyway, I think that this solution is better (instead of using the method added in #5063). I think I did not fully look into I could add the issue, but since it was "fixed" in 2.12 might be a bit weird. @Pierre-Sassoulas You decide 😄 |
There are several cases where we just say "refers to" or "refs #..." right? best of both worlds. |
I think we don't need to create issue when the problem is fixed (We can |
doc/whatsnew/<current release.rst>
.Type of Changes
Description
Needed for a PR that stops using the deprecated
cachedproperty
decorator fromastroid
.