-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #5969 for modified_iterating-list
#5986
Fix issue #5969 for modified_iterating-list
#5986
Conversation
β¦ the list/dict/set being iterated through is a function call.
Pull Request Test Coverage Report for Build 2044411171
π - Coveralls |
Thank you for the quick fix @orSolocate, we're going to release 2.13.1 shortly :) |
What do you think of the line that lost coverage as |
@Pierre-Sassoulas thanks for noticing that letting me know what the line was, |
This is released in 2.13.1 :) btw if you want to check the coverage details on coverall you need to login with your GitHub account: coveralls use it to not get rate limited for api calls. |
@Pierre-Sassoulas - thanks for merging man! and for for the coveralls tip, now I could see coverage details of my next uploads :) |
Just want to check in and say thanks @orSolocate for the quick turnaround here :) |
Thanks mate! |
Type of Changes
Description
Fix program crash for
modified_iterating-list
when the list being iterated through is a function call.The bug was fixed so that it will not occur with dictionaries and sets as well.
A regression test was added too.
Closes #5969