-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added assignment-from-no-return message example #5992
Added assignment-from-no-return message example #5992
Conversation
Co-authored-by: Vladyslav Krylasov <vladyslav.krylasov@gmail.com>
6972e92
to
c775a09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit nit picky, but let's try to keep this examples as short as possible. For a beginner, every additional line might be interpreted as necessary for the code to work or the message to go away.
Co-authored-by: DaniΓ«l van Noord <13665637+DanielNoord@users.noreply.github.com>
Co-authored-by: DaniΓ«l van Noord <13665637+DanielNoord@users.noreply.github.com>
I put print to leave example having just one single error - the one which is documented. (if print is missing there is error about not used variable). But this is just matter of taste. |
I agree with the principle but I think it will be unmanageable. For stuff which involves classes we would need to satisfy The tester has been specifically set up to only enable the message that is in the name of the directory so any other pylint messages are no issue for these. |
Pull Request Test Coverage Report for Build 2046056332
π - Coveralls |
Type of Changes
Description
Closes partially #5953