Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added assignment-from-no-return message example #5992

Merged
merged 3 commits into from
Mar 28, 2022

Conversation

matusvalo
Copy link
Collaborator

Type of Changes

Type
πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
βœ“ πŸ“œ Docs

Description

Closes partially #5953

Co-authored-by: Vladyslav Krylasov <vladyslav.krylasov@gmail.com>
@matusvalo matusvalo force-pushed the assignment-from-no-return branch from 6972e92 to c775a09 Compare March 26, 2022 23:28
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit nit picky, but let's try to keep this examples as short as possible. For a beginner, every additional line might be interpreted as necessary for the code to work or the message to go away.

doc/data/messages/a/assignment-from-no-return/bad.py Outdated Show resolved Hide resolved
doc/data/messages/a/assignment-from-no-return/good.py Outdated Show resolved Hide resolved
matusvalo and others added 2 commits March 27, 2022 00:35
Co-authored-by: DaniΓ«l van Noord <13665637+DanielNoord@users.noreply.github.com>
Co-authored-by: DaniΓ«l van Noord <13665637+DanielNoord@users.noreply.github.com>
@matusvalo
Copy link
Collaborator Author

Bit nit picky, but let's try to keep this examples as short as possible.

I put print to leave example having just one single error - the one which is documented. (if print is missing there is error about not used variable). But this is just matter of taste.

@DanielNoord
Copy link
Collaborator

Bit nit picky, but let's try to keep this examples as short as possible.

I put print to leave example having just one single error - the one which is documented. (if print is missing there is error about not used variable). But this is just matter of taste.

I agree with the principle but I think it will be unmanageable. For stuff which involves classes we would need to satisfy too-few-public-methods, all the missing-docstring messages, the no-self-use etc.
At that point we might as well write a complete module πŸ˜„

The tester has been specifically set up to only enable the message that is in the name of the directory so any other pylint messages are no issue for these.

@coveralls
Copy link

coveralls commented Mar 26, 2022

Pull Request Test Coverage Report for Build 2046056332

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.184%

Totals Coverage Status
Change from base Build 2046015559: 0.0%
Covered Lines: 15337
Relevant Lines: 16284

πŸ’› - Coveralls

@DanielNoord DanielNoord merged commit b5f15ce into pylint-dev:main Mar 28, 2022
@matusvalo matusvalo deleted the assignment-from-no-return branch March 28, 2022 09:04
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants