-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include testing_pylintrc
in source and wheel distributions
#6029
Include testing_pylintrc
in source and wheel distributions
#6029
Conversation
Pull Request Test Coverage Report for Build 2058127529
π - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it was that easy...
Thanks @jpy-git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy pasting the comment I put on the wrong issue:
There's another solution: it's to generate the default value at runtime in the testutil if the file do not exists. As those tests class are used only by downstream library maintainer this file is very seldom required so not adding it to the packaging at all will be better 99,95% of the time.
The file is relatively small so won't add much. I think having it as a separate file makes the code much cleaner. |
Type of Changes
Description
Closes #6028.
testing_pylintrc
wasn't being included in package distributions.This should fix running tests via
tox
(this is where I encountered it) and any uses ofpylint.testutils