Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for bad-str-strip-call #6090

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

DudeNr33
Copy link
Collaborator

@DudeNr33 DudeNr33 commented Apr 1, 2022

  • Write a good description on what the PR does.
  • If you used multiple emails or multiple names when contributing, add your mails
    and preferred name in script/.contributors_aliases.json

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Description

Add examples and explanation for bad-str-strip-call.

Ref: #5953

@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 1, 2022
@DanielNoord
Copy link
Collaborator

Learned something new today 😄

@DudeNr33
Copy link
Collaborator Author

DudeNr33 commented Apr 1, 2022

It also took me a long time to figure that one out. 😀 That's why I thought adding a bit more info in the details.rst would be reasonable here.

@DanielNoord
Copy link
Collaborator

It also took me a long time to figure that one out. 😀 That's why I thought adding a bit more info in the details.rst would be reasonable here.

We might also want to update the message description and what is emitted. The description is actually more helpful than the actual message.

@DudeNr33 DudeNr33 merged commit c992072 into pylint-dev:main Apr 1, 2022
@DudeNr33 DudeNr33 deleted the doc-bad-str-strip-call branch April 1, 2022 09:10
@Pierre-Sassoulas
Copy link
Member

I opened a follow-up #6093 to try to make it easier to understand without reading the python documentation

@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants