Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for missing-format-argument-key message documentation #6115

Merged
merged 2 commits into from
Apr 2, 2022
Merged

add example for missing-format-argument-key message documentation #6115

merged 2 commits into from
Apr 2, 2022

Conversation

gunungpw
Copy link
Contributor

@gunungpw gunungpw commented Apr 2, 2022

  • Write a good description on what the PR does.
  • If you used multiple emails or multiple names when contributing, add your mails
    and preferred name in script/.contributors_aliases.json

Type of Changes

Type
📜 Docs

Description

  • add code example for missing-format-argument-key
  • add PEP 3101 and Python string formatting docs to related.rst

Ref #5953

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! All your example are so... american 😄

@gunungpw
Copy link
Contributor Author

gunungpw commented Apr 2, 2022

🤣 I am afraid if the example is not a popular/normal phrase or word, a beginner like me who reads the code will confuse about what actually the code does. it's often the case if the code uses foo bar.
I am actually not from English speaking country (I am still learning English my grammar is bad :)) so the only reference I got from there was popular culture like movie 😄.

@Pierre-Sassoulas
Copy link
Member

Not saying it's a bad thing at all. But you can also integrate things from your own culture if you want.

a beginner like me who reads the code will confuse about what actually the code does. it's often the case if the code uses foo bar.

Yes I think so too, example that can be understood by school children with no prior knowledge is what we should be aiming at. Mainly because actual school children could read the examples, but also because everyone benefit from more engaging examples.

@@ -0,0 +1,2 @@
`PEP 3101 <https://peps.python.org/pep-3101/>`_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pierre-Sassoulas @gunungpw I didn't check this myself, but the related.rst documents should preferably be a list using - .... That gets formatted a little nicer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue with lists in something we merged recently see additional detail : https://pylint.pycqa.org/en/latest/messages/warning/arguments-differ.html. I think because it's rst formatting we need * instead of -.

@gunungpw gunungpw deleted the missing-format-argument-key branch April 3, 2022 03:49
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants