-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add example for missing-format-argument-key
message documentation
#6115
add example for missing-format-argument-key
message documentation
#6115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! All your example are so... american 😄
🤣 I am afraid if the example is not a popular/normal phrase or word, a beginner like me who reads the code will confuse about what actually the code does. it's often the case if the code uses |
Not saying it's a bad thing at all. But you can also integrate things from your own culture if you want.
Yes I think so too, example that can be understood by school children with no prior knowledge is what we should be aiming at. Mainly because actual school children could read the examples, but also because everyone benefit from more engaging examples. |
@@ -0,0 +1,2 @@ | |||
`PEP 3101 <https://peps.python.org/pep-3101/>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pierre-Sassoulas @gunungpw I didn't check this myself, but the related.rst
documents should preferably be a list using - ...
. That gets formatted a little nicer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an issue with lists in something we merged recently see additional detail : https://pylint.pycqa.org/en/latest/messages/warning/arguments-differ.html. I think because it's rst formatting we need *
instead of -
.
and preferred name in
script/.contributors_aliases.json
Type of Changes
Description
missing-format-argument-key
related.rst
Ref #5953