Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added literal-comparison message example #6159

Merged
merged 3 commits into from
Apr 3, 2022

Conversation

matusvalo
Copy link
Collaborator

Co-authored-by: Vladyslav Krylasov vladyslav.krylasov@gmail.com

Type of Changes

Type
πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
βœ“ πŸ“œ Docs

Description

Related #5953

Co-authored-by: Vladyslav Krylasov <vladyslav.krylasov@gmail.com>
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a function is better sometime so we have an "unknown" value and meaningful code.

doc/data/messages/l/literal-comparison/bad.py Outdated Show resolved Hide resolved
doc/data/messages/l/literal-comparison/good.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas
Copy link
Member

We should probably link to : https://docs.python.org/3/library/stdtypes.html#comparisons

@matusvalo
Copy link
Collaborator Author

We should probably link to : https://docs.python.org/3/library/stdtypes.html#comparisons

done

@Pierre-Sassoulas Pierre-Sassoulas merged commit 6718502 into pylint-dev:main Apr 3, 2022
@matusvalo matusvalo deleted the literal-comparison branch April 3, 2022 19:09
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants