Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added wrong-import-order message example #6239

Merged
merged 5 commits into from
Apr 9, 2022
Merged

Added wrong-import-order message example #6239

merged 5 commits into from
Apr 9, 2022

Conversation

matusvalo
Copy link
Collaborator

@matusvalo matusvalo commented Apr 8, 2022 •
edited by Pierre-Sassoulas
Loading

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
✓ 📜 Docs

Description

Refs #5953

@matusvalo
Copy link
Collaborator Author

isort pre-commit hook "fixed" bad.py file causing it is not showing bad case anymore :-(

@matusvalo
Copy link
Collaborator Author

Do we want to exclude isort per file

https://github.com/PyCQA/pylint/blob/0afa5bc5ea8641cce751b8f995fe8ce682f397fa/.pre-commit-config.yaml#L40

or we will exclude whole doc/data/messages directory?

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.14.0 milestone Apr 9, 2022
@Pierre-Sassoulas
Copy link
Member

we will exclude whole doc/data/messages directory?

We could exclude all the bad.py first is the 'exclude' become hard to manage

@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Apr 9, 2022
Closed
4 tasks
@matusvalo matusvalo force-pushed the wrong-import-order branch from 1a4d278 to 1a8e0cd Compare April 9, 2022 14:17
@coveralls
Copy link

coveralls commented Apr 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2140952463

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.895%
Totals Coverage Status
Change from base Build 2140528287: 0.0%
Covered Lines: 15888
Relevant Lines: 16921
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas requested changes Apr 9, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the regex, I'll revert if it breaks the existing code :)

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @matusvalo !

@Pierre-Sassoulas Pierre-Sassoulas merged commit 2d363e4 into pylint-dev:main Apr 9, 2022
@matusvalo matusvalo deleted the wrong-import-order branch April 9, 2022 14:40
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Documentation 📗
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matusvalo @Pierre-Sassoulas @coveralls