Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add super-without-brackets checker #6374

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Add super-without-brackets checker #6374

merged 3 commits into from
Apr 18, 2022

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Apr 18, 2022 •
edited
Loading

  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.
  • If you used multiple emails or multiple names when contributing, add your mails
    and preferred name in script/.contributors_aliases.json

Type of Changes

Type
✓ ✨ New feature

Description

Closes #4008

@DanielNoord DanielNoord added the Enhancement ✨ Improvement to a component label Apr 18, 2022
@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 18, 2022
@coveralls
Copy link

coveralls commented Apr 18, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2183261423

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 95.132%
Totals Coverage Status
Change from base Build 2182943301: 0.004%
Covered Lines: 15733
Relevant Lines: 16538
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas reviewed Apr 18, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new checker looks great but the issue this MR is supposed to close seems unrelated :)

@DanielNoord
Copy link
Collaborator Author

Fixed!

@DanielNoord @Pierre-Sassoulas
Update pylint/checkers/classes/class_checker.py
bf0360e 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@DanielNoord DanielNoord merged commit 5d02c05 into pylint-dev:main Apr 18, 2022
@DanielNoord DanielNoord deleted the super-brackets branch April 18, 2022 10:49
omarandlorraine pushed a commit to omarandlorraine/pylint that referenced this pull request Apr 19, 2022
@DanielNoord @Pierre-Sassoulas
Add super-without-brackets checker (pylint-dev#6374)
90be847 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

Detect super call without brackets
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas