Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for #6538 #6553

Merged
merged 4 commits into from
May 9, 2022
Merged

Add regression test for #6538 #6553

merged 4 commits into from
May 9, 2022

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

Add regression test for issue #6538

@jacobtylerwalls jacobtylerwalls added this to the 2.14.0 milestone May 9, 2022
@jacobtylerwalls jacobtylerwalls mentioned this pull request May 9, 2022
Merged
Pierre-Sassoulas
Pierre-Sassoulas approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and nice 👌

@jacobtylerwalls
Copy link
Member Author

I think there's a test isolation issue here. The test passes when run by itself.

@Pierre-Sassoulas
Copy link
Member

Could it be that the sys.path is modified by other tests ?

@jacobtylerwalls
Copy link
Member Author

jacobtylerwalls commented May 9, 2022 •
edited
Loading

More unique names help. We have a module a under tests/input/func_noerror_cycle.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 63a9124 into pylint-dev:main May 9, 2022
@jacobtylerwalls jacobtylerwalls deleted the issue-6538 branch May 9, 2022 14:52
@jacobtylerwalls jacobtylerwalls mentioned this pull request May 9, 2022
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2294804983

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 95.345%
Files with Coverage Reduction New Missed Lines %
pylint/lint/pylinter.py 3 94.65%
Totals Coverage Status
Change from base Build 2292561596: 0.004%
Covered Lines: 16017
Relevant Lines: 16799
💛 - Coveralls

@gcbirzan-plutoflume gcbirzan-plutoflume mentioned this pull request Aug 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobtylerwalls @Pierre-Sassoulas @coveralls @DanielNoord