Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continue-in-finally documentation examples #6586

Merged
merged 5 commits into from
Jun 24, 2022

Conversation

mbyrnepr2
Copy link
Member

@mbyrnepr2 mbyrnepr2 commented May 11, 2022

Add continue-in-finally documentation examples based on the pylint-errors project.

Co-authored-by: Vladyslav Krylasov vladyslav.krylasov@gmail.com

Type of Changes

Type
πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
βœ“ πŸ“œ Docs

Description

Partially addresses #5953

…-errors project.

Co-authored-by: Vladyslav Krylasov <vladyslav.krylasov@gmail.com>
@Pierre-Sassoulas Pierre-Sassoulas dismissed their stale review May 12, 2022 07:01

No warning raised in bad.py

@mbyrnepr2
Copy link
Member Author

Something to do with py_version @Pierre-Sassoulas. I copied the pylintrc from the functional tests. Can revisit later today

@Pierre-Sassoulas
Copy link
Member

We have the same issue in #6583, we probably need to set py-version because running the documentation test on multiple interpreters would be too much..

@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
@DanielNoord
Copy link
Collaborator

@mbyrnepr2 Are you still looking to finish this PR or should we close it?

@mbyrnepr2
Copy link
Member Author

@mbyrnepr2 Are you still looking to finish this PR or should we close it?

@DanielNoord sorry about the delay. I'm not sure how I can fix the CI issue. The py-version doesn't affect the test if I remember correctly.

@DanielNoord
Copy link
Collaborator

It's weird as the CI runs on 3.8. Would bumping to 3.10 help?

@mbyrnepr2
Copy link
Member Author

It's weird as the CI runs on 3.8. Would bumping to 3.10 help?

Not sure I follow - the test needs to run on something older than 3.8 to trigger the continue-in-finally message.

@DanielNoord
Copy link
Collaborator

Not sure I follow - the test needs to run on something older than 3.8 to trigger the continue-in-finally message.

Ah my bad, I mixed up my "older" with "higher number". Would the fix be to fix support for py-version for this message? I don't think we should rely on the interpreter to be able to emit certain message and instead handle such differences with that option flag.

@mbyrnepr2 mbyrnepr2 force-pushed the continue-in-finally branch from e699060 to a689344 Compare June 24, 2022 18:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2557430762

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0008%) to 95.34%

Totals Coverage Status
Change from base Build 2557379157: 0.0008%
Covered Lines: 16652
Relevant Lines: 17466

πŸ’› - Coveralls

@github-actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit a689344

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you for the extra-work on py-version @mbyrnepr2 !

@Pierre-Sassoulas Pierre-Sassoulas merged commit d7597c6 into pylint-dev:main Jun 24, 2022
@mbyrnepr2 mbyrnepr2 deleted the continue-in-finally branch June 24, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants