-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add continue-in-finally
documentation examples
#6586
Add continue-in-finally
documentation examples
#6586
Conversation
β¦-errors project. Co-authored-by: Vladyslav Krylasov <vladyslav.krylasov@gmail.com>
7b0ae9b
to
975fcc5
Compare
Something to do with py_version @Pierre-Sassoulas. I copied the pylintrc from the functional tests. Can revisit later today |
We have the same issue in #6583, we probably need to set |
@mbyrnepr2 Are you still looking to finish this PR or should we close it? |
@DanielNoord sorry about the delay. I'm not sure how I can fix the CI issue. The py-version doesn't affect the test if I remember correctly. |
It's weird as the CI runs on 3.8. Would bumping to |
Not sure I follow - the test needs to run on something older than 3.8 to trigger the |
Ah my bad, I mixed up my "older" with "higher number". Would the fix be to fix support for |
e699060
to
a689344
Compare
Pull Request Test Coverage Report for Build 2557430762
π - Coveralls |
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit a689344 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thank you for the extra-work on py-version @mbyrnepr2 !
Add
continue-in-finally
documentation examples based on thepylint-errors
project.Co-authored-by: Vladyslav Krylasov vladyslav.krylasov@gmail.com
Type of Changes
Description
Partially addresses #5953