Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ranges for error messages #6606

Merged
merged 2 commits into from
May 13, 2022
Merged

Update ranges for error messages #6606

merged 2 commits into from
May 13, 2022

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented May 13, 2022

Description

Update ranges for using-constant-test and missing-parentheses-for-call-in-test error messages.
Both should only be emitted on the test node itself and not the whole if statement.

Old
Screen Shot 2022-05-13 at 17 48 01

New
Screen Shot 2022-05-13 at 17 47 30

Related: #5466

@cdce8p cdce8p added this to the 2.14.0 milestone May 13, 2022
Pierre-Sassoulas
Pierre-Sassoulas approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !

@cdce8p cdce8p added Enhancement ✨ Improvement to a component Error range and removed Bug 🪲 labels May 13, 2022
@cdce8p cdce8p mentioned this pull request May 13, 2022
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2320526228

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.346%
Totals Coverage Status
Change from base Build 2320472050: 0.0%
Covered Lines: 16043
Relevant Lines: 16826
💛 - Coveralls

@cdce8p cdce8p merged commit 0c37d4c into pylint-dev:main May 13, 2022
@cdce8p cdce8p deleted the update-error-ranges branch May 13, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @coveralls @Pierre-Sassoulas