Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue template] Upgrade default label to match currents #7004

Merged
merged 3 commits into from
Jun 22, 2022
Merged

[issue template] Upgrade default label to match currents #7004

merged 3 commits into from
Jun 22, 2022

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✓ 📜 Docs

Description

Closes #6999

@Pierre-Sassoulas Pierre-Sassoulas added Needs review 🔍 Needs to be reviewed by one or multiple more persons Maintenance Discussion or action around maintaining pylint or the dev workflow and removed Needs review 🔍 Needs to be reviewed by one or multiple more persons labels Jun 22, 2022
@Pierre-Sassoulas
Copy link
Member Author

Asking for a review for the text/emoji used and not the actual template change, as we need a PR to fix the template if we want to change the text or emoji later.

@coveralls
Copy link

coveralls commented Jun 22, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2545131801

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.285%
Totals Coverage Status
Change from base Build 2542415183: 0.0%
Covered Lines: 16592
Relevant Lines: 17413
💛 - Coveralls

DanielNoord
DanielNoord requested changes Jun 22, 2022
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not put a double needs in the labels. If something needs triage that's a clear indication that a maintainer should do something and also signals to a reporter that that is the next course of action.

@Pierre-Sassoulas Pierre-Sassoulas merged commit ffa15a4 into pylint-dev:main Jun 22, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the use-new-labels branch June 22, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord requested changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Needs PR and Needs decision labels
3 participants
@Pierre-Sassoulas @coveralls @DanielNoord