-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to explain escape character not valid #7103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to pylint ! Indeed we should have documented this better. I think the file you modified is autogenerated, could you search for the Python file with the same text and modify this one instead, please ?
Pull Request Test Coverage Report for Build 2600560848
π - Coveralls |
Adding note from pylint-dev#5415 to docs
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, and congratulation on becoming a pylint contributor :) !
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit bf667ae |
@Pierre-Sassoulas it looks the the auto-upgrading tools rst doc removed my escape of the
What's the best way around that? Do I need to escape it again? |
Does double escape work ? |
Type of Changes
Description
This just adds the note from #5415 to docs to explain that
\
is not valid in ignore-paths per #5398 (comment) because it also currently is needed to support Windows path normalization. This will help avoid additional issues being created (like the one I created in #7089 and also someone else in #7094) to reduce the burden on pylint maintainers/developers.