Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined-loop-variable from walrus in comprehension test #7324

Merged
merged 2 commits into from
Aug 20, 2022
Merged

Fix undefined-loop-variable from walrus in comprehension test #7324

merged 2 commits into from
Aug 20, 2022

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #7222

@jacobtylerwalls jacobtylerwalls added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Aug 20, 2022
@jacobtylerwalls jacobtylerwalls added this to the 2.15.0 milestone Aug 20, 2022
@github-actions

This comment has been minimized.

Sign in to view
@jacobtylerwalls jacobtylerwalls force-pushed the issue-7222 branch 2 times, most recently from 07c91fd to 73c63cf Compare August 20, 2022 19:04
@coveralls
Copy link

coveralls commented Aug 20, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2895939117

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 95.254%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/checkers/variables.py 8 9 88.89%
Totals Coverage Status
Change from base Build 2895171551: -0.003%
Covered Lines: 16881
Relevant Lines: 17722
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas reviewed Aug 20, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good already !

pylint/checkers/variables.py Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 2c10bbe

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jacobtylerwalls jacobtylerwalls merged commit 2fafadc into pylint-dev:main Aug 20, 2022
@jacobtylerwalls jacobtylerwalls deleted the issue-7222 branch August 20, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

undefined-loop-variable in walrus in comprehension test
3 participants
@jacobtylerwalls @coveralls @Pierre-Sassoulas