Fix a crash in the modified-iterating-dict checker involving instance attributes
#7472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
the
Needs backport
jacobtylerwalls
force-pushed
the
crash-attributes
branch
from
647cb7c to
5f4ba20
Compare
Pull Request Test Coverage Report for Build 3064459061
💛 - Coveralls |
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 5f4ba20 |
Pierre-Sassoulas
approved these changes
Sep 16, 2022
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Pierre-Sassoulas
pushed a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Sep 16, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #7461
As of bcd4ca3 we know that the
iter_objis aNameor anAttribute, so tighten the typing.