Fix undefined-loop-variable with NoReturn and Never
#7476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
Needs backport
DanielNoord
commented
Sep 16, 2022
| return | ||
| ): | ||
| return | ||
| # TODO: 2.16: Consider using RefactoringChecker._is_function_def_never_returning |
There was a problem hiding this comment.
This function doesn't actually infer but uses the attrname, which we also match not_typing.we_do_return.NoReturn. That isn't really safe..
DanielNoord
commented
Sep 16, 2022
DanielNoord
changed the title
undefined-loop-variable with NoReturn and Never
This comment has been minimized.
This comment has been minimized.
Merged
jacobtylerwalls
changed the title
undefined-loop-variable with NoReturn and Neverundefined-loop-variable with NoReturn and Never
jacobtylerwalls
requested changes
Sep 17, 2022
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
previously approved these changes
Sep 17, 2022
|
Do you know what's up with the test failure? |
|
Probably incorrect checking of |
DanielNoord
dismissed stale reviews from jacobtylerwalls and Pierre-Sassoulas
via
370ec10
Pull Request Test Coverage Report for Build 3080932997
💛 - Coveralls |
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 370ec10 |
|
|
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Pierre-Sassoulas
pushed a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Sep 19, 2022
…#7476) Co-authored-by: detachhead <detachhead@users.noreply.github.com> Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towncrier create <IssueNumber>.<type>which will beincluded in the changelog.
<type>can be one of: new_check, removed_check, extension,false_positive, false_negative, bugfix, other, internal. If necessary you can write
details or offer examples on how the new change is supposed to work.
and preferred name in
script/.contributors_aliases.jsonType of Changes
Description
Continuation of #7419
@DetachHead Sorry not sure what went wrong here. I tried to push my fix to your branch but it closed the PR... Sorry about that!
This should work 😄
Tested on 3.11 locally as well.
Closes #7311