Fix a crash when looking up an __init__ method #7744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom a parent class with an ``__init__`` class attribute. Closes pylint-dev#7742
Pull Request Test Coverage Report for Build 3452454525
💛 - Coveralls |
|
Merging upstream to fix primer following suggestion in #7738 (comment) |
jacobtylerwalls
added
the
Needs backport
DanielNoord
reviewed
Nov 11, 2022
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
DanielNoord
previously approved these changes
Nov 12, 2022
|
@mbyrnepr2 The current job on |
|
I wonder if you also need to merge main. |
Pierre-Sassoulas
requested changes
Nov 12, 2022
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 162fa65 |
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Pierre-Sassoulas
added a commit
that referenced
this pull request
Nov 16, 2022
* Fix a crash when a child class with an ``__init__`` method inherits from a parent class with an ``__init__`` class attribute. * `continue` if not a method. * Update pylint/checkers/classes/class_checker.py * Rename fragment Closes #7742 Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Pierre-Sassoulas
added a commit
that referenced
this pull request
Nov 17, 2022
* Fix a crash when a child class with an ``__init__`` method inherits from a parent class with an ``__init__`` class attribute. * `continue` if not a method. * Update pylint/checkers/classes/class_checker.py * Rename fragment Closes #7742 Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix a crash when a child class with an
__init__method inherits from a parent class with an__init__class attribute.Closes #7742