Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent argument exit code when argparse exit with its own error code #7931

Merged
merged 6 commits into from
Dec 14, 2022
Merged

Fix inconsistent argument exit code when argparse exit with its own error code #7931

merged 6 commits into from
Dec 14, 2022
+58 −4

Commits on Dec 14, 2022

  1. pylint: add failing test when invalid arguments are passed 

    Returning 2 here is confusing as it doesn't match the documentation: https://pylint.pycqa.org/en/latest/user_guide/usage/run.html#exit-codes
    @dmrlawson
    dmrlawson committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    495f324 View commit details
    Browse the repository at this point in the history

  2. pylint: use exit code 32 when invalid arguments are passed

    @dmrlawson
    dmrlawson committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    4eb56df View commit details
    Browse the repository at this point in the history

  3. pylint: add failing test when ambiguous abbreviated parameters are se… 

    …t in a config file

This is confusing behaviour. The output is:

```
usage: pylint [options]
pylint: error: ambiguous option: --no could match --notes, --notes-rgx, --no-docstring-rgx
```

The exit code is 2 which doesn't match the documentation: https://pylint.pycqa.org/en/latest/user_guide/usage/run.html#exit-codes
    @dmrlawson
    dmrlawson committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    f2bbe46 View commit details
    Browse the repository at this point in the history

  4. pylint: use exit code 32 when ambiguous abbreviated parameters are se… 

    …t in a config file
    @dmrlawson
    dmrlawson committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    60097b9 View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @dmrlawson
    dmrlawson committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    b71f6ad View commit details
    Browse the repository at this point in the history

  6. Update doc/whatsnew/fragments/7931.bugfix

    @Pierre-Sassoulas
    Pierre-Sassoulas authored Dec 14, 2022
    Configuration menu
    Copy the full SHA
    244e1cf View commit details
    Browse the repository at this point in the history