-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[consider-using-augmented-assign] Do not warn for non-commutative operators #8037
[consider-using-augmented-assign] Do not warn for non-commutative operators #8037
Conversation
β¦rators Or rather, only warn for known commutative operators. Closes pylint-dev#7639
cb3bcbf
to
f965129
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8037 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 176 176
Lines 18527 18528 +1
=======================================
+ Hits 17680 17681 +1
Misses 847 847
|
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Nick Drozd <nicholasdrozd@gmail.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look. I think the anti-commutative
phrase may be misleading/mean something else (https://www.dictionary.com/browse/anticommutative#:~:text=adjective%20Mathematics.,%2C%20as%20ab%20%3D%20%E2%88%92ba.)
tests/functional/ext/code_style/cs_consider_using_augmented_assign.py
Outdated
Show resolved
Hide resolved
tests/functional/ext/code_style/cs_consider_using_augmented_assign.py
Outdated
Show resolved
Hide resolved
tests/functional/ext/code_style/cs_consider_using_augmented_assign.py
Outdated
Show resolved
Hide resolved
tests/functional/ext/code_style/cs_consider_using_augmented_assign.py
Outdated
Show resolved
Hide resolved
tests/functional/ext/code_style/cs_consider_using_augmented_assign.py
Outdated
Show resolved
Hide resolved
tests/functional/ext/code_style/cs_consider_using_augmented_assign.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Mark Byrne <31762852+mbyrnepr2@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @mbyrnepr2 !
Type of Changes
Description
Or rather, only warn for known commutative operators.
Closes #7639