-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crash] Fix crashes on python interpreter < 3.9 #8163
Conversation
That would be cool. Commit email would be marc@solute.de |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8163 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 177 177
Lines 18622 18622
=======================================
Hits 17791 17791
Misses 831 831
|
Closes pylint-dev#8161 Co-authored-by: Marc Schmitzer <marc@solute.de>
d991cf5
to
61f4f1e
Compare
Thank you for your help and congratulations on becoming a pylint contributor @MarcSchmitzer ! |
This part was not tested, it explains the crash. Should we blindly fix it or do you have a possible test in mind @DanielNoord ? |
Let's blindly fix. Can't be worse than current situation. I know this was pretty poorly tested code in general and the original fix is only because I made the typing stricter, which was already an improvement over previous state. |
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 61f4f1e |
Type of Changes
Description
Closes #8161 @MarcSchmitzer we can add you as co-author if you want (need your commit email) :)