fix no-name-in-module when variable is same as module name #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8169 +/- ##
==========================================
- Coverage 95.53% 95.44% -0.09%
==========================================
Files 177 177
Lines 18622 18635 +13
==========================================
- Hits 17791 17787 -4
- Misses 831 848 +17
|
|
the coverage report doesn't make that much sense (must be indirect coverage) |
Pierre-Sassoulas
added
the
False Positive π¦
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 71dba00 |
Pierre-Sassoulas
approved these changes
Feb 7, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> (cherry picked from commit f690448)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #8148
I was able to reproduce the original issue FP but also came up with a non-lib specific example that raised this issue.