Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[return-arg-in-generator] Add a details.rst only as the message is not raised anymore #8191

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ“œ Docs

Description

Blocked by the inclusion of deleted messages in the doc (#6670) or the inclusion of a new message template #7897

Refs #5953

@Pierre-Sassoulas Pierre-Sassoulas added Documentation πŸ“— Skip news πŸ”‡ This change does not require a changelog entry Blocked 🚧 Blocked by a particular issue labels Feb 5, 2023
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #8191 (0be39f9) into main (fc97635) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8191   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files         173      173           
  Lines       18557    18557           
=======================================
  Hits        17767    17767           
  Misses        790      790           
Files Changed Coverage Ξ”
pylint/checkers/base/basic_error_checker.py 95.51% <ΓΈ> (ΓΈ)

@ollie-iterators
Copy link
Contributor

If you are doing things that only need details.rst, I believe that the invalid-unicode-codec one only needs deatils.rst because it is about the encoding of the file.

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the add-doc-for-return-in-generator branch from e38af3d to ba06420 Compare June 3, 2023 07:04
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the add-doc-for-return-in-generator branch from ba06420 to 100eeab Compare August 9, 2023 11:56
@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label Aug 9, 2023
@mbyrnepr2
Copy link
Member

Savvy! Although could probably do with removing the word β€œoutside” from the description (not part of the current MR).

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the add-doc-for-return-in-generator branch from 100eeab to 0be39f9 Compare August 10, 2023 19:54
@Pierre-Sassoulas
Copy link
Member Author

Nice catch, I fixed it :)

@github-actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 0be39f9

@Pierre-Sassoulas Pierre-Sassoulas merged commit 0d79577 into pylint-dev:main Aug 10, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the add-doc-for-return-in-generator branch August 10, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation πŸ“— Skip news πŸ”‡ This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants