-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc unexpected-line-ending-format #8255
doc unexpected-line-ending-format #8255
Conversation
1fcd864
to
58e95c0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8255 +/- ##
=======================================
Coverage 95.46% 95.46%
=======================================
Files 177 177
Lines 18691 18698 +7
=======================================
+ Hits 17843 17850 +7
Misses 848 848
|
58e95c0
to
7008fd1
Compare
It's not that easy to commit an actual file with CRLF if all your tools are trying to smart and help you "do the right thing" π¬ |
Yes you'd need to modify our .gitattributes for that. But it's impossible to see that you did the right thing while reading the doc though :) Maybe something that don't need a bad/good that we could handle in #7897 with a nice story about the meaning and history of CRLF and type printer. |
Right now it's correct, but you're right, this is not visible in the docs. I added inline comments like in the I'm thinking about adding an explanation in a |
Might want to link this https://stackoverflow.com/a/6521730/2519059 and this https://stackoverflow.com/a/10855862/2519059 in related too. |
7008fd1
to
fed5ba4
Compare
Ok, those links are awesome and have all the info needed (I think). I added those and a link to the awesome gitattributes template repo to |
c938bee
to
56487ce
Compare
I don't get it. It worked yesterday. Now it doesn't anymore. The π€· |
56487ce
to
9625cb8
Compare
Type of Changes
Description
Add doc for unexpected-line-ending-format / C0328
Refs #5953