-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work on documentation for non-ascii-file-name #8324
Work on documentation for non-ascii-file-name #8324
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8324 +/- ##
=======================================
Coverage 95.46% 95.46%
=======================================
Files 177 177
Lines 18704 18704
=======================================
Hits 17856 17856
Misses 848 848
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This need a changelog message, and a cleanup of the existing code in the checkers, this is not going to be easy, a maintainer or someone experienced should probably do it. Also the current MR need to justify the removal if someone read it later.
Ok, I updated the MR |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the description and the changelog :) Next step would be to remove all the code related to this (functional tests, all the part of the pylint code specific to this check), do you want to do it or should we take over ?
Thanks, but I think I'll try to do it |
Ok, I removed non-ascii-file-name from all the files except for full.rst, summary.rst and the files that are necessary to show that it was removed. |
This comment has been minimized.
This comment has been minimized.
This reverts commit b78a610.
for more information, see https://pre-commit.ci
All right thank you for reverting. Let's simply document the message here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 9ee4f49 |
Thank you for working on this. Sorry I'm going to close because the first link is just something that point to PEP489 that we already linked, and the second link point to a list of non ascii character that is not relevant to the issue. Also we can actually document the problem properly see #8340 |
Type of Changes
Description
Working on documentation for non-ascii-file-name
This is because while the issue (https://bugs.python.org/issue20485) that caused this issue has been fixed since Python 3.5. It is still not recommended to use non-ascii characters in a filename.
This is the PR that fixed the issue: python/cpython#64684 (comment).
Refs #7897