[test] Use an empty pylintrc so tests to not depend on system's conf #8350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Maintenance
DanielNoord
reviewed
Feb 26, 2023
There was a problem hiding this comment.
https://github.com/PyCQA/pylint/blob/main/pylint/testutils/_run.py#L28
We can just use this class. We have fixed this issue before 😄
|
Yeah I was checking how to do that generically and I rediscovered this too 😅 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8350 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 178 178
Lines 18776 18776
=======================================
Hits 17926 17926
Misses 850 850 |
Pierre-Sassoulas
force-pushed
the
fix-8342
branch
from
df86a24 to
a5b7258
Compare
|
All right, should be better, and hopefully emulate using the test runner in new tests from now on 😄 |
| @@ -222,6 +222,7 @@ def test_allow_reexport_package(capsys: CaptureFixture[str]) -> None: | |||
| [ | |||
| f"{os.path.join(REGR_DATA, 'allow_reexport')}", | |||
| "--allow-reexport-from-package=yes", | |||
| "--disable=missing-module-docstring", | |||
There was a problem hiding this comment.
We're forced to do it this way because of the check line 232
DanielNoord
previously approved these changes
Feb 26, 2023
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2023
…8350) * [test] Use an empty pylintrc so tests to not depend on system's conf Closes #8342 * Update tests/checkers/unittest_imports.py Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com> --------- Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com> (cherry picked from commit 641f526)
Pierre-Sassoulas
added a commit
that referenced
this pull request
Feb 27, 2023
…8350) (#8351) * [test] Use an empty pylintrc so tests to not depend on system's conf Closes #8342 * Update tests/checkers/unittest_imports.py Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com> --------- Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com> (cherry picked from commit 641f526) Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #8342, and fix test that could create similar bugs with specifics configurations.