Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pylint to 2.17.0, update changelog #8395

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

No description provided.

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Mar 7, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.17.0 milestone Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #8395 (4f86e49) into main (ca25497) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8395   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files         178      178           
  Lines       18764    18764           
=======================================
  Hits        17934    17934           
  Misses        830      830           
Impacted Files Coverage Δ
pylint/checkers/refactoring/refactoring_checker.py 98.33% <ø> (ø)
pylint/checkers/unicode.py 100.00% <ø> (ø)
pylint/__pkginfo__.py 100.00% <100.00%> (ø)

DanielNoord
DanielNoord previously approved these changes Mar 7, 2023
@Pierre-Sassoulas
Copy link
Member Author

Urgh I failed to push the latest broken whitspace fix, sorry @DanielNoord .

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) March 7, 2023 21:50
@Pierre-Sassoulas Pierre-Sassoulas merged commit ee2e635 into pylint-dev:main Mar 7, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the release-branch-2.17.0 branch March 7, 2023 21:57
@jacobtylerwalls jacobtylerwalls removed their request for review March 7, 2023 21:57
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

🤖 Effect of this PR on checked open source code: 🤖

Effect on django:
The following messages are now emitted:

  1. redefined-variable-type:
    Redefinition of field type from django.db.models.fields.related.OneToOneField to django.forms.widgets.Widget
    https://github.com/django/django/blob/9a07999aef7958c9b5441e368cd90646d0edc5c9/django/db/models/base.py#L346

Effect on music21:
The following messages are now emitted:

  1. invalid-name:
    Attribute name "id" doesn't conform to '[a-z_][A-Za-z0-9_]{2,30}$' pattern
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L576
  2. useless-suppression:
    Useless suppression of 'attribute-defined-outside-init'
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3193
  3. useless-suppression:
    Useless suppression of 'attribute-defined-outside-init'
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3264
  4. redefined-variable-type:
    Redefinition of fundamental type from django.forms.widgets.Widget to music21.pitch.Pitch
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/pitch.py#L3690
  5. too-many-instance-attributes:
    Too many instance attributes (33/20)
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/roman.py#L1394
  6. redefined-variable-type:
    Redefinition of lastChord type from music21.chord.Chord to django.forms.widgets.Widget
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/analysis/neoRiemannian.py#L435
  7. redefined-variable-type:
    Redefinition of n type from music21.note.Note to music21.note.GeneralNote
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/abcFormat/translate.py#L354
  8. redefined-variable-type:
    Redefinition of sc3 type from music21.scale.MinorScale to music21.scale.MajorScale
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/scale/test_scale_main.py#L163
  9. useless-suppression:
    Useless suppression of 'method-hidden'
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/stream/base.py#L11551

The following messages are no longer emitted:

  1. invalid-name:
    Attribute name "id" doesn't conform to '[a-z_][A-Za-z0-9_]{2,30}$' pattern
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/prebase.py#L293
  2. suppressed-message:
    Suppressed 'attribute-defined-outside-init' (from line 3193)
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3193
  3. suppressed-message:
    Suppressed 'attribute-defined-outside-init' (from line 3264)
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/base.py#L3264
  4. too-many-instance-attributes:
    Too many instance attributes (34/20)
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/roman.py#L1394
  5. redefined-variable-type:
    Redefinition of sc3 type from music21.scale.MajorScale to music21.scale.MinorScale
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/scale/test_scale_main.py#L169
  6. unsubscriptable-object:
    Value 'midiEventList' is unsubscriptable
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/midi/translate.py#L1359
  7. suppressed-message:
    Suppressed 'method-hidden' (from line 11551)
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/stream/base.py#L11552

Effect on pandas:
The following messages are now emitted:

  1. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.period.PeriodArray to pandas.core.indexes.base.Index
    https://github.com/pandas-dev/pandas/blob/178e504c90ef2cfb6e2dccf5b409c3787e0a3bbe/pandas/_testing/__init__.py#L299

The following messages are no longer emitted:

  1. redefined-variable-type:
    Redefinition of expected type from pandas.core.arrays.numpy_.PandasArray to pandas.core.indexes.base.Index
    https://github.com/pandas-dev/pandas/blob/178e504c90ef2cfb6e2dccf5b409c3787e0a3bbe/pandas/_testing/__init__.py#L299

Effect on sentry:
The following messages are no longer emitted:

  1. unsubscriptable-object:
    Value '_from_email_domain_cache' is unsubscriptable
    https://github.com/getsentry/sentry/blob/5959c5be7a50c32cc79c98447807bf0521994a17/src/sentry/utils/email/address.py#L26

This comment was generated for commit 4f86e49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants