[FileState] Deprecation enactment for 3.0.0 #8407
Conversation
Pierre-Sassoulas
added
Breaking changes for 3.0 🦤
Maintenance
Pierre-Sassoulas
force-pushed
the
file-state-deprecation-enactment
branch
from
80bacb2 to
f70a2f4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8407 +/- ##
==========================================
+ Coverage 95.66% 95.67% +0.01%
==========================================
Files 176 176
Lines 18527 18510 -17
==========================================
- Hits 17723 17709 -14
+ Misses 804 801 -3
|
pylint/lint/parallel.py
Outdated
| @@ -165,6 +165,7 @@ def check_parallel( | |||
| msg_status, | |||
| mapreduce_data, | |||
| ) in executor.map(_worker_check_single_file, files): | |||
| assert isinstance(base_name, str) | |||
There was a problem hiding this comment.
This should now always be str without an assertion
There was a problem hiding this comment.
mypy does not like it:
pylint/lint/parallel.py:168: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str") [assignment]
Found 1 error in 1 file (checked 3 source files)
There was a problem hiding this comment.
The typing on PyLinter or FileState should be updated!
There was a problem hiding this comment.
I rebased so we can rebase and merge, there was quite a lot more to change than I thought :D
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Pierre-Sassoulas
force-pushed
the
file-state-deprecation-enactment
branch
from
ff744a0 to
402939c
Compare
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 402939c |
Type of Changes
Description
modnameandmsg_storeare now required to be given in FileState,collect_block_lineshas also been removed.