Deprecate redundant type checking guard utils

[jacobtylerwalls]

Type of Changes

	Type
✓	🔨 Refactoring

Description

Suggesting we backport this to 2.17.x so that we can get the notice out before 3.0.

[codecov]

Codecov Report

Merging #8433 (9a6039b) into main (74e6efc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8433      +/-   ##
==========================================
- Coverage   95.73%   95.72%   -0.01%     
==========================================
  Files         174      174              
  Lines       18392    18401       +9     
==========================================
+ Hits        17607    17614       +7     
- Misses        785      787       +2     

Impacted Files	Coverage Δ
pylint/checkers/imports.py	94.34% <100.00%> (+0.01%)	⬆️
pylint/checkers/utils.py	95.84% <100.00%> (-0.19%)	⬇️
pylint/checkers/variables.py	97.16% <100.00%> (+<0.01%)	⬆️
pylint/extensions/private_import.py	99.17% <100.00%> (ø)

... and 1 file with indirect coverage changes

[Pierre-Sassoulas]

Kinda wondering if this should be part of the astroid's node API. It would be conveniant and discoverable.

[jacobtylerwalls]

Kinda wondering if this should be part of the astroid's node API.

😅
https://github.com/PyCQA/astroid/blob/395bfbd670a6bf3fa043f5e7b509b9df5b83a714/ChangeLog#L43-L46

[Pierre-Sassoulas]

Yeah I remember that, but how are we going to handle control flow ? It seems like this is similar to control flow understanding. And imo it will need to be object oriented instead of functional if we want them to be easy to use (if there was a single function on the node for that we would not have created 3/4 identical functions to solve a single problem?).

[jacobtylerwalls]

Gotcha. I see how control flow ideas can be similar to astroid.are_exclusive. But I think with something all mixed up like this, where we're also inferring names in the middle, is not really a pure-ast-analysis thing like are_exclusive. I don't have a strong opinion though.

[Pierre-Sassoulas]

Anyway, it's going to be a design discussion in astroid later, and we need to deprecate the duplicated functions in any cases.

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 9a6039b