Also check the typealias naming style for TypeAlias variables defined in functions.

[yilei]

Type of Changes

	Type
✓	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
	📜 Docs

Description

Closes #8536

[yilei]

Btw, tests/test_check_parallel.py seems to be failing when I run tests locally at HEAD:

platform darwin -- Python 3.11.1, pytest-7.2.2, pluggy-1.0.0

...

=========================================================================================================== FAILURES ============================================================================================================
________________________________________________________________________ TestCheckParallelFramework.test_linter_with_unpickleable_plugins_is_pickleable _________________________________________________________________________

self = <test_check_parallel.TestCheckParallelFramework object at 0x10a4eb710>

    def test_linter_with_unpickleable_plugins_is_pickleable(self) -> None:
        """The linter needs to be pickle-able in order to be passed between workers"""
        linter = PyLinter(reporter=Reporter())
        # We load an extension that we know is not pickle-safe
        linter.load_plugin_modules(["pylint.extensions.overlapping_exceptions"])
        try:
            dill.dumps(linter)
>           raise AssertionError(
                "Plugins loaded were pickle-safe! This test needs altering"
            )
E           AssertionError: Plugins loaded were pickle-safe! This test needs altering

tests/test_check_parallel.py:252: AssertionError

[Pierre-Sassoulas]

Neat fix ! @DanielNoord do you have an opinion about the pickle test failing ?

[codecov]

Codecov Report

Merging #8537 (a5e55c8) into main (cb255ea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8537   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files         174      174           
  Lines       18366    18368    +2     
=======================================
+ Hits        17615    17617    +2     
  Misses        751      751           

Impacted Files	Coverage Δ
pylint/checkers/base/name_checker/checker.py	98.59% <100.00%> (+<0.01%)	⬆️

[DanielNoord]

Can we reproduce? If not I'd say just merge this

[Pierre-Sassoulas]

Reading the primer it seems some variable that are only typed are confused for a TypeAlias. For example in sentry: resolved_orderby: Union[str, SelectType, None]

[yilei]

@Pierre-Sassoulas Is "primer" the Primer actions run on this PR? Could you please point to me where the relevant outputs are? I checked those jobs but can only find generic logs without info like sentry / resolved_orderby: Union[str, SelectType, None]. Thanks!

[yilei]

@Pierre-Sassoulas Ah sorry never mind, just found out it's in a separate comment right after I posted my question. Taking a look now.

[yilei]

Rebased, the local variable declaration issue should have been fixed by #8541.

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit a5e55c8

[DanielNoord]

@Pierre-Sassoulas Do you want a review as well?

[Pierre-Sassoulas]

Neat !