Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit logging-not-lazy for explicitly concatenated strings. #8546

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

yilei
Copy link
Contributor

@yilei yilei commented Apr 6, 2023

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ“œ Docs

Description

Closes #8410

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #8546 (7780b07) into main (82cee37) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8546   +/-   ##
=======================================
  Coverage   95.90%   95.91%           
=======================================
  Files         174      174           
  Lines       18353    18366   +13     
=======================================
+ Hits        17602    17615   +13     
  Misses        751      751           
Impacted Files Coverage Ξ”
pylint/checkers/logging.py 94.87% <100.00%> (+0.16%) ⬆️
pylint/checkers/variables.py 97.17% <100.00%> (+0.01%) ⬆️

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 7780b07

@DanielNoord DanielNoord added Enhancement ✨ Improvement to a component False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/3.3.x labels Apr 7, 2023
@DanielNoord DanielNoord added this to the 2.17.3 milestone Apr 7, 2023
@DanielNoord DanielNoord merged commit eeddd66 into pylint-dev:main Apr 7, 2023
github-actions bot pushed a commit that referenced this pull request Apr 7, 2023
DanielNoord pushed a commit that referenced this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported Enhancement ✨ Improvement to a component False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pylint should not emit logging-not-lazy when using explicit string concatenation for the message
3 participants