Exit immediately if all messages are disabled #8799
Conversation
tests/test_self.py
Outdated
| def test_disable_all(self) -> None: | ||
| out = StringIO() | ||
| self._runtest([UNNECESSARY_LAMBDA, "--disable=all"], out=out, code=0) | ||
| assert "show this help message and exit" in out.getvalue().strip() |
There was a problem hiding this comment.
I'm torn on whether to print help in this case. A user might have unintentionally disabled everything due to the order of command-line arguments.
There was a problem hiding this comment.
Yeah, what about a simple No files to lint, exiting ? The help message a is a wall of text and it's not intuitive that there wasn't any files to lint when getting a wall of text..
This comment has been minimized.
This comment has been minimized.
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit c410636 |
There was a problem hiding this comment.
That's great, because often it's the first test that someone is doing when opening an issue saying that pylint is too slow. It's not going to make pylint faster in real world use case or magically create @only_required_for for disabled message but it's going to make pylint succeed at this sanity check while also displaying a nice warning message for those who disable everything 👌
Type of Changes
Description
Closes #8715 (should reduce the number of issues we get about this)
Exit immediately with the help message if all checks are disabled. Exit non-zero.