Clean up tests that had min_pyver=3.8 test setting #8811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
the
Maintenance
jacobtylerwalls
commented
Jul 1, 2023
Comment on lines
-386
to
-388
| - Fix ``used-before-assignment`` for functions/classes defined in type checking guard. | ||
|
|
||
| Closes #7368 (`#7368 <https://github.com/pylint-dev/pylint/issues/7368>`_) |
There was a problem hiding this comment.
Other cleanup 1: this was given twice, see above under 2.15.2.
| or not isinstance(node.args[0], nodes.Name) | ||
| or not isinstance(node.args[1], nodes.Name) | ||
| or node_frame_class(node) is None | ||
| # TODO: PY38: Use walrus operator, this will also fix the mypy issue |
There was a problem hiding this comment.
Other cleanup 2: resolve this TODO
Follow-up to 0754b1d.
jacobtylerwalls
force-pushed
the
more-cleanups
branch
from
e7bc294 to
90459ef
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8811 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 173 173
Lines 18510 18511 +1
=======================================
+ Hits 17750 17751 +1
Misses 760 760
|
Pierre-Sassoulas
approved these changes
Jul 3, 2023
|
Need a rebase for the primer to work ? |
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 90459ef |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Follow-up to #8792.
Closes #6306