[doc] Use the new multiple file template for A <= message-symbol < D
#9006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Documentation 📗
Skip news 🔇
14 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9006 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 173 173
Lines 18645 18645
=======================================
Hits 17853 17853
Misses 792 792 |
DanielNoord
reviewed
Sep 5, 2023
| @@ -1,2 +1,2 @@ | |||
| - `logging variable data <https://docs.python.org/3/howto/logging.html#logging-variable-data>`_ | |||
| - `rational <https://stackoverflow.com/questions/34619790>`_ | |||
| - `Rational for the message on stackoverflow <https://stackoverflow.com/a/34634301/2519059>`_ | |||
There was a problem hiding this comment.
Suggested change
| - `Rational for the message on stackoverflow <https://stackoverflow.com/a/34634301/2519059>`_ | |
| - `Rationale for the message on stackoverflow <https://stackoverflow.com/a/34634301/2519059>`_ |
There was a problem hiding this comment.
I checked rational is the adjective so that's why spell correction did not work :D ! Thank you fixed in 42bac1f
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Pierre-Sassoulas
force-pushed
the
use-new-multiple-file-template
branch
from
7353853 to
6815f67
Compare
DanielNoord
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Refs #7897
There are multiple examples for consider-using-f-string and consider-using-generator: but I think it's not worth it to separate everything. (Better to keep all the examples together in this case).