Fix crash in refactoring checker from unaryop with variable #9075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes:
```
File "python3.10/site-packages/pylint/utils/ast_walker.py", line 91, in walk
callback(astroid)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 700, in visit_for
self._check_unnecessary_list_index_lookup(node)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2227, in _check_unnecessary_list_index_lookup
has_start_arg, confidence = self._enumerate_with_start(node)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2352, in _enumerate_with_start
start_val, confidence = self._get_start_value(keyword.value)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2369, in _get_start_value
return node.operand.value, HIGH
AttributeError: 'Name' object has no attribute 'value'
```
Crash is reproducible if you have something like this:
```python
x=5
for _ in enumerate(range, start=-x):
...
```
As a workaround, remove the unary op before `for` loop (i.e. change the
variable used).
Closes pylint-dev#9074
Hnasar
force-pushed
the
fix-enumerate-refactoring-negative-var-crash
branch
from
8e14344 to
ab3e0f1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9075 +/- ##
==========================================
+ Coverage 95.57% 95.75% +0.18%
==========================================
Files 178 173 -5
Lines 18869 18664 -205
==========================================
- Hits 18034 17872 -162
+ Misses 835 792 -43
|
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit ab3e0f1 |
Pierre-Sassoulas
approved these changes
Sep 27, 2023
Pierre-Sassoulas
added
Crash 💥
github-actions bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
Fixes:
```
File "python3.10/site-packages/pylint/utils/ast_walker.py", line 91, in walk
callback(astroid)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 700, in visit_for
self._check_unnecessary_list_index_lookup(node)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2227, in _check_unnecessary_list_index_lookup
has_start_arg, confidence = self._enumerate_with_start(node)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2352, in _enumerate_with_start
start_val, confidence = self._get_start_value(keyword.value)
File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2369, in _get_start_value
return node.operand.value, HIGH
AttributeError: 'Name' object has no attribute 'value'
```
Crash is reproducible if you have something like this:
```python
x=5
for _ in enumerate(range, start=-x):
...
```
As a workaround, remove the unary op before `for` loop (i.e. change the
variable used).
Closes #9074
Co-authored-by: Hashem Nasarat <hashem@hudson-trading.com>
(cherry picked from commit aa29201)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Sep 27, 2023
…9076) Fixes: ``` File "python3.10/site-packages/pylint/utils/ast_walker.py", line 91, in walk callback(astroid) File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 700, in visit_for self._check_unnecessary_list_index_lookup(node) File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2227, in _check_unnecessary_list_index_lookup has_start_arg, confidence = self._enumerate_with_start(node) File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2352, in _enumerate_with_start start_val, confidence = self._get_start_value(keyword.value) File "python3.10/site-packages/pylint/checkers/refactoring/refactoring_checker.py", line 2369, in _get_start_value return node.operand.value, HIGH AttributeError: 'Name' object has no attribute 'value' ``` Crash is reproducible if you have something like this: ```python x=5 for _ in enumerate(range, start=-x): ... ``` As a workaround, remove the unary op before `for` loop (i.e. change the variable used). Closes #9074 Co-authored-by: Hashem Nasarat <hashem@hudson-trading.com> (cherry picked from commit aa29201) Co-authored-by: Nazia Povey <Hnasar@users.noreply.github.com>
|
Are Hashem Nasarat and Nazia Povey the same person or should they be credited separately ? |
|
Hashem is fine, thanks! |
|
I'm trying to populate the alias file here: https://github.com/pylint-dev/pylint/blob/main/script/.contributors_aliases.json#L55 Would this work for you ? "Hnasar@users.noreply.github.com": {
"mails": ["Hnasar@users.noreply.github.com", "hashem@hudson-trading.com"],
"name": "Hashem Nasarat"
},(Due to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Crash is reproducible if you have something like this:
As a workaround, remove the unary op before
forloop (i.e. change the variable used).Closes #9074
Type of Changes