Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade astroid to 2.15.8 on 2.17.x branch #9081

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

jacobtylerwalls
Copy link
Member

Backport of #9071.

@jacobtylerwalls jacobtylerwalls added this to the 2.17.7 milestone Sep 30, 2023
@jacobtylerwalls
Copy link
Member Author

@mbyrnepr2 Do you mind taking over and fixing the 3.7 test? 🙏

@mbyrnepr2
Copy link
Member

mbyrnepr2 commented Sep 30, 2023

Happy to do that @jacobtylerwalls and thanks for doing all this work related to issues of mine recently!
Is it necessary to backport tests like this? Our main branch CI doesn't run tests for Python 3.7 anymore since it is end of life so does it make sense to update the tests to handle the no-member (in the currently failing CI for this PR)?

@jacobtylerwalls
Copy link
Member Author

Good point, no, not necessarily, unless the test reveals a real incompatibility with the stuff we're about to backport. Sounds like no (i.e. just an issue with the test having slightly different output?)

@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Sep 30, 2023

I think it's ok to more or less silently "drop support for python 3.7" (i.e. simply removing the tests and changing packaging metadata, not actually doing what we did on main) in the latest 2.17.x. Especially if we still support 2.17.x it at the same time than 3.0.x maintenance branch following 3.0.0 release.

@jacobtylerwalls
Copy link
Member Author

Alright, let's just merge the astroid upgrade, and do a pylint patch release.

Especially if we still support 2.17.x it at the same time than 3.0.x maintenance branch following 3.0.0 release.

-1 on merging anything else to the 2.17.x maintenance branch ever again, honestly.

@jacobtylerwalls jacobtylerwalls changed the title [Backport maintenance/2.17.x] Add regression tests for #9069 Upgrade astroid on 2.17.x branch Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #9081 (4b3d009) into maintenance/2.17.x (aed51a6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           maintenance/2.17.x    #9081   +/-   ##
===================================================
  Coverage               95.57%   95.57%           
===================================================
  Files                     178      178           
  Lines                   18869    18869           
===================================================
  Hits                    18034    18034           
  Misses                    835      835           

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind :)

@Pierre-Sassoulas Pierre-Sassoulas merged commit c2907a9 into maintenance/2.17.x Sep 30, 2023
24 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the tests-typevar branch September 30, 2023 20:59
@Pierre-Sassoulas Pierre-Sassoulas changed the title Upgrade astroid on 2.17.x branch Upgrade astroid to 2.15.8 on 2.17.x branch Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants