-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade astroid to 2.15.8 on 2.17.x branch #9081
Conversation
@mbyrnepr2 Do you mind taking over and fixing the 3.7 test? 🙏 |
Happy to do that @jacobtylerwalls and thanks for doing all this work related to issues of mine recently! |
Good point, no, not necessarily, unless the test reveals a real incompatibility with the stuff we're about to backport. Sounds like no (i.e. just an issue with the test having slightly different output?) |
I think it's ok to more or less silently "drop support for python 3.7" (i.e. simply removing the tests and changing packaging metadata, not actually doing what we did on main) in the latest 2.17.x. Especially if we still support 2.17.x it at the same time than 3.0.x maintenance branch following 3.0.0 release. |
Alright, let's just merge the astroid upgrade, and do a pylint patch release.
-1 on merging anything else to the 2.17.x maintenance branch ever again, honestly. |
be33ca5
to
4b3d009
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## maintenance/2.17.x #9081 +/- ##
===================================================
Coverage 95.57% 95.57%
===================================================
Files 178 178
Lines 18869 18869
===================================================
Hits 18034 18034
Misses 835 835 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind :)
Backport of #9071.