Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive for inherit-non-class for generic Protocols #9108

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

DanielNoord
Copy link
Collaborator

Type of Changes

Type
🐛 Bug fix

Description

Closes #9106.

Thought I would make a PR, has been a while 😄

Fixes a false positive which is apparently a regression in 3.x.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #9108 (ab1a8be) into main (f74200d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9108   +/-   ##
=======================================
  Coverage   95.75%   95.76%           
=======================================
  Files         173      173           
  Lines       18663    18663           
=======================================
+ Hits        17871    17872    +1     
+ Misses        792      791    -1     
Files Coverage Δ
pylint/checkers/classes/class_checker.py 93.38% <100.00%> (+0.10%) ⬆️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit ab1a8be

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Glad to see you're back to the PR business :D !

@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Oct 4, 2023
@Pierre-Sassoulas Pierre-Sassoulas merged commit cd4b292 into pylint-dev:main Oct 4, 2023
46 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 4, 2023
@DanielNoord DanielNoord deleted the fix-9106 branch October 4, 2023 05:45
Pierre-Sassoulas pushed a commit that referenced this pull request Oct 4, 2023
…9108) (#9111)

(cherry picked from commit cd4b292)

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive inherit-non-class when inheriting a generic Protocol
2 participants