Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport maintenance/3.0.x] Fix a crash for Enum class decorated with dataclass #9112

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 4, 2023

Backport 2c3425d from #9104.

* Fix a crash when an enum class which is also decorated with a ``dataclasses.dataclass`` decorator is defined.

Closes #9100

* Update test to mention the `astroid` issue that addresses the missing ``__members__`` object.

* Use an `if` instead of the `try/except` block.

* Update pylint/checkers/utils.py

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>

---------

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
(cherry picked from commit 2c3425d)
@Pierre-Sassoulas Pierre-Sassoulas added the Crash 💥 A bug that makes pylint crash label Oct 4, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.1 milestone Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #9112 (259cf91) into maintenance/3.0.x (2d8a894) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           maintenance/3.0.x    #9112   +/-   ##
==================================================
  Coverage              95.76%   95.76%           
==================================================
  Files                    173      173           
  Lines                  18663    18665    +2     
==================================================
+ Hits                   17872    17874    +2     
  Misses                   791      791           
Files Coverage Δ
pylint/checkers/utils.py 95.94% <100.00%> (+<0.01%) ⬆️

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) October 4, 2023 12:21
@Pierre-Sassoulas Pierre-Sassoulas merged commit a1443ed into maintenance/3.0.x Oct 4, 2023
21 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-9104-to-maintenance/3.0.x branch October 4, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crash 💥 A bug that makes pylint crash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants