[release] Fix 3.2.4's release date following twine 5.1.0's issues #9749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
Pierre-Sassoulas
force-pushed
the
fix-release
branch
from
06a3d1b to
8fbb612
Compare
|
Planning to release 3.2.5 directly and not try to fix the 3.2.4 release to prevent mismatch between the existing tag and the version on pypi, but I'm open to suggestion. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9749 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 174 174
Lines 18878 18878
=======================================
Hits 18094 18094
Misses 784 784 |
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 8fbb612 |
jacobtylerwalls
previously approved these changes
Jun 25, 2024
|
Yeah, let's just go to 3.2.5 and mention in the release note there is no functional difference. |
DanielNoord
reviewed
Jun 26, 2024
Pierre-Sassoulas
changed the title
Pierre-Sassoulas
force-pushed
the
fix-release
branch
from
8fbb612 to
c344e3c
Compare
Pierre-Sassoulas
added
the
Skip news 🔇
|
Yeap, re-running the release job worked. 👌 Thank you @DanielNoord |
Pierre-Sassoulas
changed the title
Pierre-Sassoulas
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
) See pypa/twine#1125 (cherry picked from commit d8f84b0)
Pierre-Sassoulas
added a commit
that referenced
this pull request
Jun 26, 2024
) (#9750) See pypa/twine#1125 (cherry picked from commit d8f84b0) Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
See https://github.com/pylint-dev/pylint/actions/runs/9668507699/job/26672818926 and pypa/twine#1125