Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #9981

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add tests #9981

merged 1 commit into from
Oct 1, 2024

Conversation

nickdrozd
Copy link
Contributor

Type of Changes

Type
🧪 Tests

Description

Add tests for open issues #9668, #9815, #8893, #9941, #9642, and #9689. Some are false negatives and some are false positives.

@nickdrozd nickdrozd added the Skip news 🔇 This change does not require a changelog entry label Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (b9cc6b2) to head (f5ea1bd).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9981   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files         174      174           
  Lines       18946    18946           
=======================================
  Hits        18152    18152           
  Misses        794      794           

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Sep 29, 2024
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you mind cleaning up the commit tree, look like something we would want to rebase and not squash. (Also you can add the tests / 🧪 in the MR template if you want :) )

@nickdrozd
Copy link
Contributor Author

I can fix up the commits, but it will require rerunning all the tests to update their output. Could you merge #9982 first so I can run Pytest?

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clean up, I meant doing a fixup of the one commit that was failing to have 4 separate commits :) I could have squashed without you doing the rebase. Does not matter that much, I'll merge as is.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 74c49b2 into pylint-dev:main Oct 1, 2024
26 checks passed
@nickdrozd nickdrozd deleted the add-tests branch October 7, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants