-
Notifications
You must be signed in to change notification settings - Fork 10
[ref:more-cargo-blocks] Breakers and miners #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LordIdra
commented
Dec 25, 2025
- Remove hydraulic excavator
- Add hydraulic breaker
- Add hydraulic miner
- Add diesel breaker
- Add diesel miner
…bsidian miner, and hydraulic cobblestone miner
|
breaker breaks block without outputing item |
|
when miner/breaker breaks container, inner items won't be dropped or saved, except shulker box. |
|
miner break bedrock (very fast! with any tool!) |
Lmao what the hell, how did I miss that All issues should be fixed, thanks for testing 👍 |
OhmV-IR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't pass the ingame vibe check

- Error when breaking things using a breaker with an item that isn't a tool (eg creative fluid source block)
[00:39:06 ERROR]: [PylonCore] Error when handling block(pylonbase:hydraulic_miner, Location{world=CraftWorld{name=world},x=7.0,y=70.0,z=-53.0,pitch=0.0,yaw=0.0}) ticking: Cannot invoke "java.lang.Integer.intValue()" because the return value of "org.bukkit.inventory.ItemStack.getData(io.papermc.paper.datacomponent.DataComponentType$Valued)" is null
[00:39:06 WARN]: java.lang.NullPointerException: Cannot invoke "java.lang.Integer.intValue()" because the return value of "org.bukkit.inventory.ItemStack.getData(io.papermc.paper.datacomponent.DataComponentType$Valued)" is null
[00:39:06 WARN]: at pylon-base-1.0.0-SNAPSHOT.jar//io.github.pylonmc.pylon.base.content.machines.hydraulics.HydraulicMiner.onProcessFinished(HydraulicMiner.java:206)
[00:39:06 WARN]: at pylon-core-1.0.0-SNAPSHOT.jar//io.github.pylonmc.pylon.core.block.base.PylonProcessor.finishProcess(PylonProcessor.kt:72)
[00:39:06 WARN]: at pylon-core-1.0.0-SNAPSHOT.jar//io.github.pylonmc.pylon.core.block.base.PylonProcessor.progressProcess(PylonProcessor.kt:89)
[00:39:06 WARN]: at pylon-base-1.0.0-SNAPSHOT.jar//io.github.pylonmc.pylon.base.content.machines.hydraulics.HydraulicMiner.tick(HydraulicMiner.java:172)
[00:39:06 WARN]: at pylon-core-1.0.0-SNAPSHOT.jar//io.github.pylonmc.pylon.core.block.base.PylonTickingBlock$Companion$startTicker$1.invokeSuspend(PylonTickingBlock.kt:159)
[00:39:06 WARN]: at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
[00:39:06 WARN]: at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
[00:39:06 WARN]: at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:78)
[00:39:06 WARN]: at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:474)
[00:39:06 WARN]: at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1744)
[00:39:06 WARN]: at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1618)
[00:39:06 WARN]: at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:430)
[00:39:06 WARN]: at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1338)
[00:39:06 WARN]: at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:384)
[00:39:06 WARN]: at java.base/java.lang.Thread.run(Thread.java:1474) - Diesel miner randomly stops working when in a setup with multiple diesel miners side by side in the same chunk
- Diesel breaker works without any diesel
Still left for me to test: - Diesel hammerhead
- Diesel mixing attachment
- Diesel pipe bender
- Diesel press
- Diesel table saw
- hydraulic hammer head
- diesel smeltery heater
- code review
|
oh here's some extra errors when stopping my server too: [01:09:34 ERROR]: Could not pass event PylonChunkBlocksUnloadEvent to PylonCore v1.0.0-SNAPSHOT |
This is the BANE OF MY EXISTENCE. I think miners/breakers breaking blocks that are part of multiblocks will just have to be a feature |
|
All errors should be fixed, thanks for finding em. Tried to prevent placing miners within their mining radius as their behaviour makes no sense when next to each other anyway (and not sure how to make it make sense) but ran into a host of issues... so think I might leave it for now. The current behaviour where all but one just stop working if there are multiple too close together is acceptable IMO |
|
Bug: diesel breaker doesnt detect sand fallen into the front |
Seggan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
Co-authored-by: Seggan <seggan21@gmail.com>
