PylonTickingEntity

[Intybyte]

Fixes #456

[LordIdra]

There's a few things missing here - I would suggest including the following in this PR, but if you don't want to do them in this PR just make sure open issues for them so we can keep track:

• Needs async ticking option as we have for blocks
• Needs error handling (we have error handling set up for other entity interfaces)
• Currently you're using a getter for tickDelay, but the convention with these sorts of interface variables is to use setTickInterval and setAsync and so on. The reason for this is to avoid having loads of getters for trivial properties which became quite a problem especially w/ the fluid stuff. It should hopefully be fairly straightforward as you can replicate what ticking blocks do.

(also docs :P - you can just do something similar to the block tickers for this)

[LordIdra]

One small thing but otherwise I'm happy

[Seggan]

Other than Idra comments LGTM

[LordIdra]

Sorry 1 big issue that I missed in my previous pass

[LordIdra]

2 small things for clarity. no event handling going on here so would be best to call it something like logTickingErr and change the message to "Error when ticking entity"

[LordIdra]

Shouldn't serialization be happening on serialize, not on add? Just checked and there's no event for this... I would add PylonEntitySerialize and PylonEntityDeserialize events here for consistency with blocks, because AFAICT this will not work properly if only called on PylonEntityAdd (won't respect tick inteval set later)