Skip to content

Add PylonProcessor + various small changes #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LordIdra merged 6 commits into from
Dec 30, 2025
Merged

Add PylonProcessor + various small changes #523

LordIdra merged 6 commits into from
Dec 30, 2025

Conversation

@LordIdra
Copy link
Contributor

@LordIdra LordIdra commented Dec 14, 2025

  • Add PylonProcessor, a version of the PylonRecipeProcessor for any arbitrary process (like fuel burning)
  • Adds postInitialise, which runs after either constructor is called
  • Merges TickManager with PylonTickingBlock to follow convention
  • Removes setupLogisticGroups, this can be done in postInitialise now
  • Changes PylonRecipeProcessor to have a progressRecipe method instead of overriding tick for improved flexibility

@LordIdra LordIdra mentioned this pull request Dec 14, 2025
Merged
OhmV-IR
OhmV-IR requested changes Dec 21, 2025
View reviewed changes
Copy link
Contributor

@OhmV-IR OhmV-IR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 tiny things and another design disagreement

@LordIdra LordIdra requested a review from OhmV-IR December 21, 2025 21:49
OhmV-IR
OhmV-IR approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@OhmV-IR OhmV-IR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM CW

Base automatically changed from pylon-recipe-processor to master December 30, 2025 12:39
@LordIdra LordIdra merged commit 84994ac into master Dec 30, 2025
3 checks passed
@LordIdra LordIdra deleted the recipe-processor-conversion branch December 30, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Seggan Seggan Seggan approved these changes

@OhmV-IR OhmV-IR OhmV-IR approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LordIdra @Seggan @OhmV-IR