Copper specific interface #527
Conversation
| */ | ||
| fun changeWaxing(event: PlayerInteractEvent) | ||
|
|
||
| companion object : Listener { |
There was a problem hiding this comment.
this should go in BlockListener by convention
There was a problem hiding this comment.
No, we are already listening to that event in BlockListener and for now i want to keep the same priority
There was a problem hiding this comment.
Can you not have two function that listen to the same event in a listener? I thought you could but maybe I'm wrong
There was a problem hiding this comment.
Yes you can, but they need to be different priority or one won't be registered, or at least from what i remember
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/block/base/PylonCopperBlock.kt
Outdated
Show resolved
Hide resolved
pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/block/base/PylonCopperBlock.kt
Show resolved
Hide resolved
| logEventHandleErr(event, e, pylonBlock) | ||
| } | ||
| } else { | ||
| event.isCancelled = true |
There was a problem hiding this comment.
!!!!! if we right click a block with an axe that is a copper variant and it's not a pylon block it will cancel the event? doesn't this just mean that all vanilla copper blocks will be unwaxable?
There was a problem hiding this comment.
it is man, how are you testing? did you update the branch?
Fixes #528